fix: form signature #752
Closed
fix: form signature #752
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PavelPancocha
commented
Sep 18, 2024
| *args, | ||
| **kwargs, | ||
| ) -> None: | ||
| super().__init__(request, *args, **kwargs) | ||
| super().__init__(*args, **kwargs) |
There was a problem hiding this comment.
There is no "request" in this form. Only data as first argument. Why it worked fine: Djano uses it as a positional only -> the "request" was "data"
- Fix wrong typing - Improve code
PavelPancocha
force-pushed
the
fix/forms_signature
branch
from
4c8163d to
441fd90
Compare
|
Would you mind to create appropriate issue for this ticket explaining in detail what we want to achieve? |
Closed
|
@lukasvinclav here you go: #760 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix: #760