[ch39212] Transfer History #3827
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fpbonet
reviewed
Feb 11, 2025
fpbonet
reviewed
Feb 11, 2025
fpbonet
reviewed
Feb 11, 2025
|
|
||
| try: | ||
| history = transfer.add_transfer_history( | ||
| origin_transfer_pk=transfer_origin_pk, transfer_pk=transfer.pk, original_transfer_pk=original_transfer_pk |
fpbonet
reviewed
Feb 11, 2025
fpbonet
reviewed
Feb 11, 2025
| history = transfer.add_transfer_history( | ||
| origin_transfer_pk=transfer_origin_pk, transfer_pk=transfer.pk, original_transfer_pk=original_transfer_pk | ||
| ) | ||
| transfer.set_transfer_history(history, save=True) |
There was a problem hiding this comment.
Let's just have 1 method add_transfer_history and then an explicit .save()
There was a problem hiding this comment.
We could think adding a .save_history() method to Transfer that only saves the transfer_history field
fpbonet
reviewed
Feb 11, 2025
fpbonet
reviewed
Feb 11, 2025
fpbonet
approved these changes
Feb 11, 2025
fpbonet
reviewed
Feb 13, 2025
Comment on lines
108
to
133
| from_partner = models.ForeignKey( | ||
| PartnerOrganization, | ||
| on_delete=models.SET_NULL, | ||
| null=True, blank=True, | ||
| related_name='transfer_history_from_partner' | ||
| ) | ||
| destination_partner = models.ForeignKey( | ||
| PartnerOrganization, | ||
| on_delete=models.SET_NULL, | ||
| null=True, blank=True, | ||
| related_name='transfer_history_destination_partner' | ||
| ) | ||
| origin_point = models.ForeignKey( | ||
| PointOfInterest, | ||
| on_delete=models.SET_NULL, | ||
| null=True, blank=True, | ||
| related_name='transfer_history_origin_point' | ||
| ) | ||
| destination_point = models.ForeignKey( | ||
| PointOfInterest, | ||
| on_delete=models.SET_NULL, | ||
| null=True, blank=True, | ||
| related_name='transfer_history_destination_point' | ||
| ) | ||
|
|
||
| comment = models.TextField(null=True, blank=True) |
There was a problem hiding this comment.
After discussion, let's please remove, as they are redundant. The transfer already knows origin, destination, points, etc.
fpbonet
reviewed
Feb 13, 2025
| logger.warning(f"Item has no transfer : {instance}") | ||
| return # No transfer available, exit early | ||
|
|
||
| transfer_origin_pk = getattr(transfer.origin_transfer, "pk", None) |
There was a problem hiding this comment.
Let's simplify by just using the item.original_transfer
fpbonet
reviewed
Feb 13, 2025
| @@ -93,6 +93,50 @@ def save(self, **kwargs): | |||
| super().save(**kwargs) | |||
|
|
|||
|
|
|||
| class TransferHistoryManager(models.Manager): | |||
| def get_or_build_by_origin_id(self, *origin_id_candidates): | |||
There was a problem hiding this comment.
As discussed together, let's simplify for only 2 parameters.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.