chore: add resource allocations to helm charts

unicef · Feb 17, 2025 · 0fcb026 · 0fcb026
1 parent 664d4cc
commit 0fcb026
Show file tree

Hide file tree

Showing 4 changed files with 17 additions and 24 deletions.
diff --git a/data_sharing/migrations/versions/c2ed12933e52_initial.py b/data_sharing/migrations/versions/c2ed12933e52_initial.py
@@ -6,7 +6,8 @@
 
 """
 
-from typing import Sequence, Union
+from collections.abc import Sequence
+from typing import Union
 
 import sqlalchemy as sa
 from alembic import op

diff --git a/infra/helm/data-sharing-delta/values.yaml b/infra/helm/data-sharing-delta/values.yaml
@@ -56,17 +56,13 @@ ingress:
   #    hosts:
   #      - chart-example.local
 
-resources: { }
-# We usually recommend not to specify default resources and to leave this as a conscious
-# choice for the user. This also increases chances charts run on environments with little
-# resources, such as Minikube. If you do want to specify resources, uncomment the following
-# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
-# limits:
-#   cpu: 100m
-#   memory: 128Mi
-# requests:
-#   cpu: 100m
-#   memory: 128Mi
+resources:
+  requests:
+    cpu: 50m
+    memory: 1Gi
+  limits:
+    cpu: 1
+    memory: 5Gi
 
 autoscaling:
   enabled: false

diff --git a/infra/helm/data-sharing-proxy/values.yaml b/infra/helm/data-sharing-proxy/values.yaml
@@ -68,17 +68,13 @@ ingress:
   #    hosts:
   #      - chart-example.local
 
-resources: { }
-# We usually recommend not to specify default resources and to leave this as a conscious
-# choice for the user. This also increases chances charts run on environments with little
-# resources, such as Minikube. If you do want to specify resources, uncomment the following
-# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
-# limits:
-#   cpu: 100m
-#   memory: 128Mi
-# requests:
-#   cpu: 100m
-#   memory: 128Mi
+resources:
+  requests:
+    cpu: 50m
+    memory: 150Mi
+  limits:
+    cpu: 1
+    memory: 1Gi
 
 autoscaling:
   enabled: false

diff --git a/scripts/load_fixtures.py b/scripts/load_fixtures.py
@@ -23,7 +23,7 @@ async def main(fixtures: list[str]):
         if not fixture_file.exists():
             raise FileNotFoundError(f"Fixture `{fixture}` could not be found.")
 
-        with open(fixture_file, "r") as f:
+        with open(fixture_file) as f:
             data = yaml.safe_load(f)
 
         try: