Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

payment plan refactor #4597

Open
wants to merge 60 commits into
base: develop
Choose a base branch
from
Open

payment plan refactor #4597

wants to merge 60 commits into from

Conversation

MarekBiczysko
Copy link
Contributor

@MarekBiczysko MarekBiczysko commented Jan 28, 2025

@MarekBiczysko MarekBiczysko marked this pull request as draft January 28, 2025 14:10
Copy link

codecov bot commented Jan 28, 2025

Codecov Report

Attention: Patch coverage is 39.77273% with 159 lines in your changes missing coverage. Please review.

Project coverage is 53.78%. Comparing base (e81e660) to head (815e78e).

Files with missing lines Patch % Lines
...api/apps/payment/services/payment_plan_services.py 6.81% 41 Missing ⚠️
...t_mis_api/apps/payment/services/payment_gateway.py 0.00% 36 Missing ⚠️
src/hct_mis_api/apps/payment/models/payment.py 56.25% 21 Missing ⚠️
src/hct_mis_api/apps/payment/admin.py 55.55% 20 Missing ⚠️
...t/xlsx/xlsx_payment_plan_export_per_fsp_service.py 0.00% 15 Missing ⚠️
..._mis_api/apps/payment/migrations/0016_migration.py 54.54% 10 Missing ⚠️
src/hct_mis_api/apps/payment/schema.py 80.64% 6 Missing ⚠️
..._mis_api/apps/payment/migrations/0017_migration.py 72.72% 3 Missing ⚠️
src/hct_mis_api/apps/payment/mutations.py 0.00% 3 Missing ⚠️
...pps/payment/pdf/payment_plan_export_pdf_service.py 0.00% 2 Missing ⚠️
... and 1 more

❌ Your patch check has failed because the patch coverage (39.77%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4597      +/-   ##
===========================================
- Coverage    60.90%   53.78%   -7.13%     
===========================================
  Files          545      547       +2     
  Lines        35947    35898      -49     
===========================================
- Hits         21894    19306    -2588     
- Misses       14053    16592    +2539     
Flag Coverage Δ
e2e 53.78% <39.77%> (-7.13%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@MarekBiczysko MarekBiczysko marked this pull request as ready for review February 11, 2025 22:30
Copy link
Contributor

@pavlo-mk pavlo-mk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BE looks good

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants