Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/remove admin area #4609

Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Feature/remove admin area #4609

wants to merge 16 commits into from

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Jan 31, 2025

No description provided.

Ommited commit hooks to just track work
…HH-collect_individual_date,-admin_area,-registration_id

# Conflicts:
#	src/hct_mis_api/apps/registration_datahub/schema.py
#	tests/unit/apps/household/test_household_query.py
#	tests/unit/apps/household/test_individual_query.py
#	tests/unit/one_time_scripts/test_migrate_data_to_representations.py
#	tests/unit/one_time_scripts/test_migrate_data_to_representations_performance.py
#	tests/unit/one_time_scripts/test_migrate_data_to_representations_unit.py
…HH-collect_individual_date,-admin_area,-registration_id

# Conflicts:
#	src/hct_mis_api/apps/household/celery_tasks.py
#	src/hct_mis_api/apps/household/migrations/0004_migration.py
#	src/hct_mis_api/one_time_scripts/migrate_data_to_representations.py
#	tests/unit/apps/household/test_models.py
…HH-collect_individual_date,-admin_area,-registration_id
…HH-collect_individual_date,-admin_area,-registration_id
Copy link

codecov bot commented Jan 31, 2025

Codecov Report

Attention: Patch coverage is 21.95122% with 32 lines in your changes missing coverage. Please review.

Project coverage is 25.62%. Comparing base (445dd41) to head (6353e01).
Report is 47 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/household/schema.py 0.00% 20 Missing ⚠️
src/hct_mis_api/apps/core/utils.py 11.11% 8 Missing ⚠️
src/hct_mis_api/api/endpoints/rdi/upload.py 0.00% 1 Missing ⚠️
src/hct_mis_api/apps/household/celery_tasks.py 50.00% 1 Missing ⚠️
src/hct_mis_api/apps/household/models.py 50.00% 1 Missing ⚠️
...s/household/services/household_recalculate_data.py 50.00% 1 Missing ⚠️

❌ Your patch check has failed because the patch coverage (21.95%) is below the target coverage (95.00%). You can increase the patch coverage or adjust the target coverage.

❗ There is a different number of reports uploaded between BASE (445dd41) and HEAD (6353e01). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (445dd41) HEAD (6353e01)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4609       +/-   ##
============================================
- Coverage    85.31%   25.62%   -59.69%     
============================================
  Files          535      536        +1     
  Lines        36837    36279      -558     
============================================
- Hits         31427     9298    -22129     
- Misses        5410    26981    +21571     
Flag Coverage Δ
e2e 25.62% <21.95%> (-34.98%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant