Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean logging and sentry logging setup #4611

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

johniak
Copy link
Contributor

@johniak johniak commented Feb 4, 2025

This pull request includes several changes to improve the logging level across various functions in the codebase. The primary change involves replacing logger.exception and logger.error with logger.warning to adjust the severity of the logged messages.

Changes to logging levels:

Copy link

codecov bot commented Feb 4, 2025

Codecov Report

Attention: Patch coverage is 0% with 146 lines in your changes missing coverage. Please review.

Project coverage is 60.74%. Comparing base (aa51409) to head (e4411be).
Report is 48 commits behind head on develop.

Files with missing lines Patch % Lines
src/hct_mis_api/apps/targeting/validators.py 0.00% 10 Missing ⚠️
...s_api/apps/targeting/services/targeting_service.py 0.00% 9 Missing ⚠️
src/hct_mis_api/apps/core/flex_fields_importer.py 0.00% 8 Missing ⚠️
src/hct_mis_api/apps/payment/mutations.py 0.00% 7 Missing ⚠️
src/hct_mis_api/apps/account/admin/mixins.py 0.00% 6 Missing ⚠️
...rc/hct_mis_api/apps/core/services/rapid_pro/api.py 0.00% 6 Missing ⚠️
src/hct_mis_api/apps/core/kobo/api.py 0.00% 5 Missing ⚠️
src/hct_mis_api/apps/program/validators.py 0.00% 5 Missing ⚠️
src/hct_mis_api/apps/account/microsoft_graph.py 0.00% 4 Missing ⚠️
..._mis_api/apps/accountability/services/verifiers.py 0.00% 4 Missing ⚠️
... and 48 more

❗ There is a different number of reports uploaded between BASE (aa51409) and HEAD (e4411be). Click for more details.

HEAD has 1 upload less than BASE
Flag BASE (aa51409) HEAD (e4411be)
unittests 1 0
Additional details and impacted files
@@             Coverage Diff              @@
##           develop    #4611       +/-   ##
============================================
- Coverage    85.32%   60.74%   -24.59%     
============================================
  Files          539      538        -1     
  Lines        36736    36690       -46     
============================================
- Hits         31346    22288     -9058     
- Misses        5390    14402     +9012     
Flag Coverage Δ
e2e 60.74% <0.00%> (-0.03%) ⬇️
unittests ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant