CLDR-18074 Add specific-non-location -> specific location fallback #4183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
reviewed
Jan 6, 2025
docs/ldml/tr35-dates.md
Outdated
| 1. America/Buenos_Aires → "Buenos Aires Time" | ||
| * America/Buenos_Aires → "Buenos Aires Time" // multiple zones in AR | ||
| * Asia/Shanghai → "China Time" // Asia/Shanghai is the _primaryZone_ for CN | ||
| * Asia/Shanghai → "China Summer Time" // daylight |
There was a problem hiding this comment.
This all looks good, with one caveat. In the examples, it looks like Asia/Shanghai can arbitrarily produce two different values. I think there is an implicit additional parameter, which we can add to make it clear what is happening. (Might also reformat as a table in that case, for clarity, and to have the comment in a separate column.)
|
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
macchiati
approved these changes
Jan 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
CLDR-18074
Also CLDR-18084
ALLOW_MANY_COMMITS=true