-
Notifications
You must be signed in to change notification settings - Fork 388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-18212 Update copyright to 2025 #4271
Conversation
Ran the following scripts to re-generate the year in copyright stamps ``` mvn package -DskipTests=true java -jar tools/cldr-code/target/cldr-code.jar GenerateDtd java -jar tools/cldr-code/target/cldr-code.jar GenerateTestData java -jar tools/cldr-code/target/cldr-code.jar GenerateValidityXML java -jar tools/cldr-code/target/cldr-code.jar CLDRModify -d common/main/ ```
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we do not need to bump all copyrights
We don't need to update ALL files!! Only files that actually change. |
we don't need to update the © on generated files unless they are actually regenerated. We do need to update the top README copyright. but not every single copyright. |
Removed the changes from SED and am just doing the ones from the generating scripts
56f2a3e
to
3cae8a3
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm RSLGTM for now.
I think in the future it would be better to fix all tools to only bump copyright if something actually changes, and otherwise revert. That would help us see more accurately if a file really changes
@srl295 Yea, that makes sense. It would be good to add "only update year if file changed" to the generating output is different. IMHO it also would be good to add checksums to generated files to help protect against manual changes (the changes should be overrides during generation). The reason I preferred doing this (bulk copyright update) is that these scripts today will update copyrights all over the place if we run them, polluting other PRs. This isolates the unrelated changes in 1 PR. However I understand that we don't need to update the copyright if we have not updated the code inside... |
Checksums - hm. Actually, what I would propose instead would be automation - CI jobs that do the regeneration and error and/or make a PR if something would changes.
And I 100% agree for the supplemental data pieces, etc. we don't need those conflicting more than they already do. I'm referring to common/main/* and similar, which normally only change when there's a manual update or a ST change, but aren't normally regenerated |
Ran the following scripts to re-generate the year in copyright stamps or update
Unfortunately
GenerateDerivedAnnotations
did not work on my computer so I did not run that.All other files updated with
sed 's/© 1991-2024/© 1991-2025/g' *
CLDR-18212
ALLOW_MANY_COMMITS=true