Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CLDR-16821 Fix Australian time zone names #4301

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jan 22, 2025

CLDR-16821

This adds exemplar cities for some islands, and aligns the en metazone names with the correct names from en-AU.

  • This PR completes the ticket.

ALLOW_MANY_COMMITS=true

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/en_AU.xml is different
  • common/main/en.xml is different
  • common/main/root.xml is now changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

@robertbastian robertbastian changed the title Fix Australian generic time zone names Fix Australian time zone names Jan 22, 2025
@AEApple
Copy link
Contributor

AEApple commented Jan 22, 2025

Why did the exemplar cities in root get re-ordered? It makes it more difficult to read the diff, so I'm curious about the motivation.

@robertbastian
Copy link
Member Author

Because as the list is growing it's becoming hard to locate a zone if it's not alphabetic. It's in a separate commit so it's easier to review.

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/root.xml is no longer changed in the branch

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The locale files are all processed for release. Any changes in the ordering will be discarded, so it just causes problems in the diff for reviewers. If you want to change the wording, then you should create a new ticket to change the ordering that the tooling produces.

@robertbastian
Copy link
Member Author

robertbastian commented Jan 22, 2025

I've removed the root.xml change, but I'm keeping en.xml sorted.

@robertbastian robertbastian changed the title Fix Australian time zone names CLDR-16821 Fix Australian time zone names Jan 22, 2025
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@jira-pull-request-webhook
Copy link

Notice: the branch changed across the force-push!

  • common/main/en.xml is different

View Diff Across Force-Push

~ Your Friendly Jira-GitHub PR Checker Bot

Copy link
Member

@macchiati macchiati left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please don't sort in the future. It makes it painful to review_, and it is reversed by the tooling!_
If you think they should be sorted differently, please file a different ticket.

@macchiati macchiati merged commit ec7c66a into unicode-org:main Jan 23, 2025
9 checks passed
@robertbastian robertbastian deleted the australian branch January 23, 2025 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants