-
Notifications
You must be signed in to change notification settings - Fork 389
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CLDR-16821 Fix Australian time zone names #4301
Conversation
2b139f1
to
11a3508
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
Why did the exemplar cities in root get re-ordered? It makes it more difficult to read the diff, so I'm curious about the motivation. |
Because as the list is growing it's becoming hard to locate a zone if it's not alphabetic. It's in a separate commit so it's easier to review. |
11a3508
to
c739040
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The locale files are all processed for release. Any changes in the ordering will be discarded, so it just causes problems in the diff for reviewers. If you want to change the wording, then you should create a new ticket to change the ordering that the tooling produces.
I've removed the root.xml change, but I'm keeping en.xml sorted. |
c739040
to
f11af5a
Compare
Hooray! The files in the branch are the same across the force-push. 😃 ~ Your Friendly Jira-GitHub PR Checker Bot |
f11af5a
to
c7437d7
Compare
Notice: the branch changed across the force-push!
~ Your Friendly Jira-GitHub PR Checker Bot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please don't sort in the future. It makes it painful to review_, and it is reversed by the tooling!_
If you think they should be sorted differently, please file a different ticket.
CLDR-16821
This adds exemplar cities for some islands, and aligns the
en
metazone names with the correct names fromen-AU
.ALLOW_MANY_COMMITS=true