Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ICU-22453 Fix non null terminated buffer issue. #2541

Closed
wants to merge 1 commit into from
Closed

ICU-22453 Fix non null terminated buffer issue. #2541

wants to merge 1 commit into from

Conversation

FrankYFTang
Copy link
Contributor

@FrankYFTang FrankYFTang commented Aug 5, 2023 •
edited
Loading

Checklist
  • Required: Issue filed: https://unicode-org.atlassian.net/browse/ICU-22453
  • Required: The PR title must be prefixed with a JIRA Issue number.
  • Required: The PR description must include the link to the Jira Issue, for example by completing the URL in the first checklist item
  • Required: Each commit message must be prefixed with a JIRA Issue number.
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

richgillam
richgillam approved these changes Aug 7, 2023
View reviewed changes
Copy link
Contributor

@richgillam richgillam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

icu4c/source/test/intltest/uniquecharstrtst.cpp Show resolved Hide resolved
@FrankYFTang
Copy link
Contributor Author

somehow the PR does not getting my latest force push to https://github.com/FrankYFTang/icu/tree/ICU-22453-string-add See FrankYFTang@12e69db

@FrankYFTang
Copy link
Contributor Author

this PR is strange. I gave up. Create another one in #2543. and clsoe this one

@FrankYFTang FrankYFTang closed this Aug 7, 2023
@FrankYFTang FrankYFTang mentioned this pull request Aug 7, 2023
Merged
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sffc sffc sffc requested changes

@richgillam richgillam richgillam approved these changes

Assignees

@sffc sffc

@richgillam richgillam

Labels
waiting-on-reviewer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@FrankYFTang @sffc @richgillam