DataIdentifier #5103
Merged
DataIdentifier #5103
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
force-pushed
the
id
branch
2 times, most recently
from
0524e50 to
81f0af9
Compare
Merged
robertbastian
added a commit
that referenced
this pull request
Jun 25, 2024
* Remove `icu_provider::datagen::DataConverter`, it's unused and has been for a while * Move `icu_provider::datagen::Iterable[Dynamic]DataProvider` to the top-level (with the other provider traits), behind the `std` feature * With #5103 we can make it return `BTreeMap`, so it won't need `std` * This removes the `datagen` feature from `icu_provider_adapters` * Rename `datagen` feature to `export`, as `icu_provider_{baked,blob,fs}` call it `export`, and it doesn't do datagen
robertbastian
requested review from
sffc,
Manishearth,
aethanyc,
makotokato,
zbraniecki,
pdogr,
snktd,
eggrobin,
nordzilla,
hsivonen,
echeran and
a team
as code owners
robertbastian
removed request for
aethanyc,
zbraniecki,
hsivonen,
echeran,
makotokato,
eggrobin and
pdogr
Manishearth
previously approved these changes
Jun 26, 2024
sffc
requested changes
Jun 26, 2024
| @@ -466,14 +466,18 @@ where | |||
| + DataProvider<XidStartV1Marker>, | |||
| NP: ?Sized, | |||
| { | |||
| fn iter_requests(&self) -> Result<HashSet<(DataLocale, DataMarkerAttributes)>, DataError> { | |||
| fn iter_ids(&self) -> Result<HashSet<DataIdentifierCow>, DataError> { | |||
There was a problem hiding this comment.
Nit: I think we should use _identifiers instead of _ids
|
|
||
| impl<'a> DataIdentifierBorrowed<'a> { | ||
| /// TODO | ||
| pub fn for_locale(locale: &'a DataLocale) -> Self { |
There was a problem hiding this comment.
Issue: The function here is named for_locale but down below it is from_locale
There was a problem hiding this comment.
from_ is for an owned conversion, for_ is for references
Comment on lines
+856
to
+857
| && !(morphed_id.locale.is_empty() | ||
| && morphed_id.marker_attributes.is_empty()) |
There was a problem hiding this comment.
Suggestion: can you write this as !morphed_id.is_empty() ?
There was a problem hiding this comment.
I don't really want to define too much logic on DataIdentifier
sffc
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new union of
DataLocaleandDataMarkerAttributes. Unlike the previousDataLocalewith auxiliary keys, there's an owned and a borrowed version.