Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pattern and skeleton modules to provider #5744

Merged
merged 15 commits into from
Oct 30, 2024
Merged

Conversation

sffc
Copy link
Member

@sffc sffc commented Oct 29, 2024

#1317

These are internal types used primarily for datagen and databake.

I need to move these now because I need both namespaces for new public types.

I also changed things from pub to pub(crate) where possible and deleted resulting dead code.

@sffc sffc marked this pull request as ready for review October 30, 2024 00:13
@sffc sffc requested review from zbraniecki and removed request for a team, zbraniecki and robertbastian October 30, 2024 00:14
Copy link
Member

@Manishearth Manishearth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not looking too closely at the actual moved files

@sffc sffc merged commit 67a3904 into unicode-org:main Oct 30, 2024
28 checks passed
@sffc sffc deleted the pattern-move branch October 30, 2024 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants