Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split specific names map #5762

Closed
wants to merge 3 commits into from
Closed

Split specific names map #5762

wants to merge 3 commits into from

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Nov 1, 2024 •
edited
Loading

This is actually only a 2.5% data saving 🤷

@robertbastian robertbastian force-pushed the zonevar branch 2 times, most recently from b67f044 to fad11ea Compare November 4, 2024 10:22
@robertbastian robertbastian marked this pull request as ready for review November 4, 2024 14:03
sffc
sffc requested changes Nov 4, 2024
View reviewed changes
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It makes some locales bigger because now you have 4 ZeroMaps instead of 2 in the fields of the formatter.

Can you write this such that we don't have more ZeroMaps?

This directly impacts memory use over FFI.

@robertbastian
Copy link
Member Author

Can you write this such that we don't have more ZeroMaps?

No, that's the purpose of this PR.

Don't we have size tests for neo formatter? They seem to be unimpacted.

@robertbastian robertbastian requested a review from sffc November 5, 2024 08:49
@robertbastian
Copy link
Member Author

  • This increases stack size, and heap size in FFI
  • This makes adding more zone variants a data-breaking change in the future
  • This slightly decreases data size

Conclusion: don't merge, maybe investigate other models in the future (@sffc, @robertbastian)

@robertbastian robertbastian deleted the zonevar branch November 7, 2024 13:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Manishearth Manishearth Manishearth approved these changes

@zbraniecki zbraniecki Awaiting requested review from zbraniecki zbraniecki is a code owner

@sffc sffc Awaiting requested review from sffc sffc is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@robertbastian @sffc @Manishearth