Bump versions of semver-broken crates to {N+1}-dev
#5769
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
Manishearth,
sffc,
filmil,
echeran and
a team
as code owners
Merged
robertbastian
force-pushed
the
beta
branch
2 times, most recently
from
9bb4375 to
80f6078
Compare
robertbastian
added a commit
that referenced
this pull request
Nov 4, 2024
robertbastian
requested review from
nordzilla,
zbraniecki and
younies
as code owners
robertbastian
changed the title
2.0.0-beta1{N+1}-dev
younies
approved these changes
Nov 4, 2024
|
Merging to fix main |
|
Strongly in support of this. It should be a release task to add "-dev" on the next version after we publish the release. |
|
It should only be added once there's a change that requires a version bump. |
|
I think for utils crates we should not add |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think we should in the future do this as soon as we make a semver-breaking change anywhere, as it's much harder to do this after the fact. We can use the
-devtag to avoid bumping a crate twice, and it's easy to remove the tag before a release (or replace withbeta).