-
Notifications
You must be signed in to change notification settings - Fork 183
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Store data path hash instead of string in binary #5886
Conversation
@Manishearth What do you think about this approach? The actual path strings are used in two places:
This PR makes the Debug impl use the hash and FsDataProvider get the path from the registry. One thing that puzzles me is the size of tutorials_buffer.wasm.
My expectation is that the size should go up on row 2 and down on rows 3 and 4, but it is basically the opposite of my expectation. I've inspected the assembly and I have no explanation for this. |
279a8d3
to
759930e
Compare
I like this, as long as datagen is able to speak in terms of the regular paths and debugging hashes is not too hard. Which I think will be fine with the registry.
Is the path included in the binary elsewhere? I bet something else includes it so it gets reused. |
Briefly discussed in the WG call. @Manishearth and @hsivonen are supportive of the change, and @sffc will continue to investigate the binary size issue. |
@robertbastian I still have a lot on my plate for 2.0. Would you mind taking a look at this PR, reproducing and possibly fixing the binary size regression shown above? |
Edit: due to the rebase the numbers from Shane's post are no longer accurate. New baselines
|
Your latest changes look good; thanks. Still no idea why the binary size changes in the opposite direction than expected. How do you suggest we proceed? |
I will stare at this more. |
Replaced by #5981 |
Proof-of-concept for #4991