Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Time and DateTime to timezone component #5961

Merged
merged 1 commit into from
Jan 14, 2025

Conversation

robertbastian
Copy link
Member

@robertbastian robertbastian commented Jan 8, 2025

Fixes #5859

@robertbastian robertbastian changed the title Time, DateTime, and ZonedDateTime to timzone component Time, DateTime, and ZonedDateTime to timezone component Jan 8, 2025
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks about right so far; thanks!

@robertbastian robertbastian force-pushed the types branch 4 times, most recently from 6099469 to da5f6b9 Compare January 14, 2025 17:38
@robertbastian robertbastian changed the title Time, DateTime, and ZonedDateTime to timezone component Time and DateTime to timezone component Jan 14, 2025
@robertbastian robertbastian force-pushed the types branch 4 times, most recently from 94c5d40 to 83b8c24 Compare January 14, 2025 19:53
@robertbastian robertbastian marked this pull request as ready for review January 14, 2025 21:32
@robertbastian robertbastian requested review from sffc and removed request for zbraniecki January 14, 2025 21:32
Copy link
Member

@sffc sffc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

@robertbastian robertbastian merged commit cc68692 into unicode-org:main Jan 14, 2025
28 checks passed
@robertbastian robertbastian deleted the types branch January 14, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Thin DateTime type in icu_timezone
2 participants