IXDTF parsers: Improve docs and add PartialEq #5993
Conversation
| /// use icu_timezone::{IxdtfParser, TimeZoneInfo, UtcOffset}; | ||
| /// | ||
| /// let tz_from_offset = IxdtfParser::new() | ||
| /// .try_offset_only_from_str("2024-08-08T12:08:19-05:00", Gregorian) | ||
| /// .try_offset_only_from_str("2024-08-08T12:08:19-05:00", Iso) |
There was a problem hiding this comment.
I don't think using Iso as the calendar argument is a good example. First of all, you could be using try_offset_only_from_iso_str, and second Iso doesn't implement CldrCalendar, so it needs to be converted before formatting.
There was a problem hiding this comment.
I don't want to overuse Gregorian in docs. It is an antipattern because it is a "strong" calendar in the sense that it overrides the locale calendar during formatting if using a FixedCalendarDTF, which exists for code size only. Better style is to get the calendar from somewhere and then pass it into the parse function, not hardcode something. ISO is slightly better in this example because it can't be used for formatting. I was concerned about this in your PR earlier but didn't want to stop it from landing.
There was a problem hiding this comment.
maybe just a mix of calendars then?
#5739
This is mostly docs. The only non-docs is adding PartialEq bounds, including to DateTime and ZonedDateTime, which became reachable via one of my new docs tests. I think adding PartialEq to DateTime is not in contradiction to the thin DateTime effort.