Update ICU data to 78 #7025
Merged
Update ICU data to 78 #7025
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
a team,
Manishearth,
echeran,
hsivonen and
sffc
as code owners
robertbastian
commented
Oct 6, 2025
Manishearth
previously approved these changes
Oct 6, 2025
sffc
reviewed
Oct 7, 2025
provider/source/src/lib.rs
Outdated
Comment on lines
238
to
248
| let url = if tag >= "release-78.1" { | ||
| format!( | ||
| "https://github.com/unicode-org/icu/releases/download/{tag}/icu4x-exportdata-{}.zip", | ||
| tag.replace("release-", "") | ||
| ) | ||
| } else { | ||
| format!( | ||
| "https://github.com/unicode-org/icu/releases/download/{tag}/icuexportdata_{}.zip", | ||
| tag.replace('/', "-") | ||
| ) | ||
| }; |
There was a problem hiding this comment.
Suggestion:
- Keep the
/to-substitution, in addition to the "release-" substitution - Special-case "release-77.1" and any other releases that this datagen version is compatible with
There was a problem hiding this comment.
Based on the agreement with the ICU TC, this change is no longer necessary.
hsivonen
requested changes
Oct 7, 2025
There was a problem hiding this comment.
AFAICT, this pessimizes the compressibility check that before this change was formulated to validate the length upon construction so that bound checking was elided at access time. Perhaps that's not super-important, but it still seems bad to break that property if we could avoid breaking that property.
components/collator/src/provider.rs
Outdated
| let field = self | ||
| .last_primaries | ||
| .get(MaxVariable::Currency as usize + usize::from(b >> 4)) | ||
| .unwrap_or_else(|| CollationSpecialPrimaries::HARDCODED_FALLBACK[usize::from(b >> 4)]); |
There was a problem hiding this comment.
To keep the above comment true, shouldn't the compressibility bits be referenced as a fixed-length array in the collator constructor instead of doing slice access on every call to this method?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#6787
Fixes #7034