Skip to content

Month type #7147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 9 commits into
base: main
Choose a base branch
from
Open

Month type #7147

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
4f8616e
ValidMonthCode -> Month
robertbastian Oct 22, 2025
817bfa4
use Month in ecma_reference_year methods
robertbastian Nov 6, 2025
6ee4db2
public API
robertbastian Oct 22, 2025
c0b6e78
update tests
robertbastian Nov 6, 2025
04dd29f
remove deref
robertbastian Nov 6, 2025
f16641f
some more tests
robertbastian Nov 6, 2025
9212d02
unhide and deprecate
robertbastian Nov 6, 2025
66393e6
month_number cleanup, formatting getters
robertbastian Nov 6, 2025
7a039fb
diplomat
robertbastian Nov 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 3 additions & 12 deletions components/calendar/benches/date.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -152,32 +152,23 @@ fn date_benches(c: &mut Criterion) {
"calendar/chinese_cached",
&fxs,
icu::calendar::cal::ChineseTraditional::new(),
|y, m, d, c| {
Date::try_new_from_codes(None, y, types::MonthCode::new_normal(m).unwrap(), d, c)
.unwrap()
},
|y, m, d, c| Date::try_new_from_codes(None, y, types::Month::new(m).code(), d, c).unwrap(),
);

bench_calendar(
&mut group,
"calendar/dangi_cached",
&fxs,
icu::calendar::cal::KoreanTraditional::new(),
|y, m, d, c| {
Date::try_new_from_codes(None, y, types::MonthCode::new_normal(m).unwrap(), d, c)
.unwrap()
},
|y, m, d, c| Date::try_new_from_codes(None, y, types::Month::new(m).code(), d, c).unwrap(),
);

bench_calendar(
&mut group,
"calendar/hebrew",
&fxs,
icu::calendar::cal::Hebrew,
|y, m, d, c| {
Date::try_new_from_codes(None, y, types::MonthCode::new_normal(m).unwrap(), d, c)
.unwrap()
},
|y, m, d, c| Date::try_new_from_codes(None, y, types::Month::new(m).code(), d, c).unwrap(),
);

bench_calendar(
Expand Down
Loading
Loading