add enumerated property NumericType to icu_properties #7157
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
m4rch3n1ng
requested review from
a team,
Manishearth,
robertbastian and
sffc
as code owners
|
|
m4rch3n1ng
force-pushed
the
numeric-type
branch
2 times, most recently
from
1eb2117 to
ae8c118
Compare
Manishearth
approved these changes
Oct 23, 2025
sffc
approved these changes
Nov 3, 2025
provider/source/src/tests/data.rs
Outdated
| ("uprops/small/Alpha.toml", include_bytes!("../../tests/data/icuexport/uprops/small/Alpha.toml").as_slice()), | ||
| ("uprops/small/Basic_Emoji.toml", include_bytes!("../../tests/data/icuexport/uprops/small/Basic_Emoji.toml").as_slice()), | ||
| ("uprops/small/bc.toml", include_bytes!("../../tests/data/icuexport/uprops/small/bc.toml").as_slice()), | ||
| ("uprops/small/nt.toml", include_bytes!("../../tests/data/icuexport/uprops/small/nt.toml").as_slice()), |
There was a problem hiding this comment.
Observation: seems to not be in alphabetical order (here and elsewhere). I think it goes between nfkdinert and Pat_Syn
m4rch3n1ng
force-pushed
the
numeric-type
branch
from
ae8c118 to
015ff65
Compare
m4rch3n1ng
force-pushed
the
numeric-type
branch
from
015ff65 to
ca21812
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
did not find an existing issue issue, but i needed (wanted) to read this property and found out it wasn't available, so here it is ...