-
Notifications
You must be signed in to change notification settings - Fork 237
Add fuzzing for calendar arithmetic code #7206
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
crashes v8 takes forever to run but eventually fails without crashing |
bf25241 to
6381e08
Compare
6381e08 to
75593cc
Compare
|
I've done the same thing I did in my original PR: constrained the fuzzer appropriately to match our client usage (which I'm changing in boa-dev/temporal#615). As we start to fix these issues we can relax the fuzzer. This keeps the fuzzer useful: I am able to fuzz what is (or will be) deployed in client use cases, while we can always locally tweak it as our confidence range expands. |
…es before passing to ICU4X (#615) We have some panics we should be avoiding here unicode-org/icu4x#7206
This also updates the constructor fuzzer with the latest code. I guess it doesn't get CI'd.
I split out the "construct a date" code into common.rs so it can be reused.
These fuzzers appear to be running smoothly. I had to cap
dayvalues for theaddfuzzer within Temporal range, though I think in the long run ICU4X should be throwing out of range errors for sufficiently large duration values.