fix: fixed frontend test test_torch_unfold for paddle backend#28601
Merged
Ishticode merged 1 commit intounifyai:mainfrom Mar 21, 2024
Merged
fix: fixed frontend test test_torch_unfold for paddle backend#28601Ishticode merged 1 commit intounifyai:mainfrom
test_torch_unfold for paddle backend#28601Ishticode merged 1 commit intounifyai:mainfrom
Conversation
ivy-leaves
added
Ivy Functional API
PyTorch Frontend
Ishticode
suggested changes
Mar 16, 2024
Contributor
Ishticode
left a comment
Ishticode
left a comment
There was a problem hiding this comment.
Hi @ZenithFlux
Thank you very much for the PR.
Two requests
the fix in parse slice might be irrelevant as this helper might disappear after merging of #28582
dtype filtering should be done on the function in the respective backend/frontend using supported or unsupported dtype decorator. Hope that makes sense :)
ZenithFlux
force-pushed
the
fixing_test_torch_unfold
branch
from
b875d5a to
084bbc9
Compare
Contributor
Author
|
@Ishticode The decorator is not working for this case. This was acknowledged by vedpatwardhan in Discord. This is a temporary fix for now. If this fix should not be merged, I can close this PR and pick another issue. I have removed parse slice fix. |
Added an assumption so that bfloat arrays are not passed to paddle backend.
ZenithFlux
force-pushed
the
fixing_test_torch_unfold
branch
from
084bbc9 to
ceb2612
Compare
Ishticode
approved these changes
Mar 21, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
bfloatdtype. Since a direct backend implementation is not called, I could not restrict dtypes through decorators.Related Issue
Closes #28600
Checklist