Skip to content

Conversation

@lupsalexandra33
Copy link
Contributor

This PR adds a new example for running a simple HTTP server using Java 25.

Files Added:

  • SimpleHttpServer.java: The application source code.
  • Dockerfile: Build rules, using the openjdk:25-rc-oraclelinux9 base image.
  • Kraftfile: Defines dependencies, and sets the Java 25 runtime path and entrypoint.
  • README.md: Instructions to set up and use the example.

Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. See my comments. Apart from these, all is well. I need to test.

Convert this PR from draft PR to a full PR.

@lupsalexandra33 lupsalexandra33 marked this pull request as ready for review December 11, 2025 20:04
@razvand razvand self-requested a review December 12, 2025 20:36
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Squash both commits into a single one.

The Kraftfile must be an example Kraftfile, a smaller one, not the current Kraftfile, which is a big one.

Take a look into PR #239 . Ideally that's what you would have:

  • A library commit in library/java/25/.
  • An example commit in examples/httpserver-java25/.
  • An example commit using the base runtime in examples/httpserver-java25-base/.

@razvand razvand self-assigned this Dec 12, 2025
@razvand razvand added the enhancement New feature or request label Dec 12, 2025
@lupsalexandra33 lupsalexandra33 force-pushed the add-java-25 branch 7 times, most recently from 147e0cd to a55746c Compare December 12, 2025 23:52
@razvand razvand self-requested a review December 13, 2025 10:46
Copy link
Contributor

@razvand razvand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sign-off your commits.

See my comments.

Test your work.

Be patient, careful and rigorous.

Comment on lines 8 to 29

unikraft:
source: https://github.com/unikraft/unikraft.git
version: staging

kconfig:
CONFIG_LIBPOSIX_PROCESS: y
CONFIG_LIBPOSIX_TIME: y
CONFIG_LIBPOSIX_SOCKET: y
CONFIG_LIBPOSIX_FDIO: y
CONFIG_LIBPOSIX_FDTAB: y

libraries:
lwip:
source: https://github.com/unikraft/lib-lwip.git
version: staging
kconfig:
CONFIG_LWIP_TCP: y
CONFIG_LWIP_SOCKET: y

targets:
- qemu/x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove these.

Add runtime: base:latest.

Look into other ...-base/ directories, see how the Kraftfile looks like.

Test your work. I followed the instructions in the README.md for your work and it didn't work.

Pay attention. Be patient. Be rigorous. Test. Test again. Make it good.

Comment on lines 8 to 29

unikraft:
source: https://github.com/unikraft/unikraft.git
version: staging

kconfig:
CONFIG_LIBPOSIX_PROCESS: y
CONFIG_LIBPOSIX_TIME: y
CONFIG_LIBPOSIX_SOCKET: y
CONFIG_LIBPOSIX_FDIO: y
CONFIG_LIBPOSIX_FDTAB: y

libraries:
lwip:
source: https://github.com/unikraft/lib-lwip.git
version: staging
kconfig:
CONFIG_LWIP_TCP: y
CONFIG_LWIP_SOCKET: y

targets:
- qemu/x86_64
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same as above, this goes away.

Add a line runtime: java:25.

@lupsalexandra33 lupsalexandra33 force-pushed the add-java-25 branch 2 times, most recently from 009b9c8 to cea6f07 Compare December 13, 2025 13:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants