-
Notifications
You must be signed in to change notification settings - Fork 78
feat(examples): Introduce new Java 25 example #244
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
razvand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. See my comments. Apart from these, all is well. I need to test.
Convert this PR from draft PR to a full PR.
razvand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Squash both commits into a single one.
The Kraftfile must be an example Kraftfile, a smaller one, not the current Kraftfile, which is a big one.
Take a look into PR #239 . Ideally that's what you would have:
- A library commit in
library/java/25/. - An example commit in
examples/httpserver-java25/. - An example commit using the
baseruntime inexamples/httpserver-java25-base/.
147e0cd to
a55746c
Compare
razvand
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sign-off your commits.
See my comments.
Test your work.
Be patient, careful and rigorous.
|
|
||
| unikraft: | ||
| source: https://github.com/unikraft/unikraft.git | ||
| version: staging | ||
|
|
||
| kconfig: | ||
| CONFIG_LIBPOSIX_PROCESS: y | ||
| CONFIG_LIBPOSIX_TIME: y | ||
| CONFIG_LIBPOSIX_SOCKET: y | ||
| CONFIG_LIBPOSIX_FDIO: y | ||
| CONFIG_LIBPOSIX_FDTAB: y | ||
|
|
||
| libraries: | ||
| lwip: | ||
| source: https://github.com/unikraft/lib-lwip.git | ||
| version: staging | ||
| kconfig: | ||
| CONFIG_LWIP_TCP: y | ||
| CONFIG_LWIP_SOCKET: y | ||
|
|
||
| targets: | ||
| - qemu/x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove these.
Add runtime: base:latest.
Look into other ...-base/ directories, see how the Kraftfile looks like.
Test your work. I followed the instructions in the README.md for your work and it didn't work.
Pay attention. Be patient. Be rigorous. Test. Test again. Make it good.
examples/httpserver-java25/Kraftfile
Outdated
|
|
||
| unikraft: | ||
| source: https://github.com/unikraft/unikraft.git | ||
| version: staging | ||
|
|
||
| kconfig: | ||
| CONFIG_LIBPOSIX_PROCESS: y | ||
| CONFIG_LIBPOSIX_TIME: y | ||
| CONFIG_LIBPOSIX_SOCKET: y | ||
| CONFIG_LIBPOSIX_FDIO: y | ||
| CONFIG_LIBPOSIX_FDTAB: y | ||
|
|
||
| libraries: | ||
| lwip: | ||
| source: https://github.com/unikraft/lib-lwip.git | ||
| version: staging | ||
| kconfig: | ||
| CONFIG_LWIP_TCP: y | ||
| CONFIG_LWIP_SOCKET: y | ||
|
|
||
| targets: | ||
| - qemu/x86_64 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same as above, this goes away.
Add a line runtime: java:25.
009b9c8 to
cea6f07
Compare
Signed-off-by: Lupsa Alexandra <[email protected]>
e2af833 to
f03df9f
Compare
This PR adds a new example for running a simple HTTP server using Java 25.
Files Added: