Allow passing a path for the android and iOS project locations #41
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unimonkiez
requested changes
Feb 28, 2023
| }, | ||
| }; | ||
|
|
||
| const config = getConfig({ rootPath }); | ||
| const config = getConfig({ rootPath, androidProjectPath: platforms.android.projectPath, iosProjectPath: platforms.ios.projectPath, }); |
There was a problem hiding this comment.
Breaking change for the node api (not cli) since now must provide paths for the projects
| module.exports = ({ rootPath }) => { | ||
| const iosPath = path.resolve(rootPath, 'ios'); | ||
| const androidPath = path.resolve(rootPath, 'android'); | ||
| module.exports = ({ rootPath, androidProjectPath, iosProjectPath }) => { |
There was a problem hiding this comment.
Default values could have been here like so
{ rootPath, androidProjectPath = 'android', iosProjectPath = 'ios' }
lib/cli.js
Outdated
| iosProjectPath: { | ||
| cliParams: ['-ios-p', '--ios-project-path'], | ||
| type: 'value', | ||
| default: 'ios', |
There was a problem hiding this comment.
can be removed from here if the default value is given in the node api
In the case of not having a standard project structure, we should still be able to link the assets
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The project I'm working on (just an Android app) has an existing android app structure we don't want to modify. Thus our android project is not in the
androidfolder of the project root. To be able to link the assets I needed a custom path.These paths default to the current
androidandioslocations unless overriden