Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update cli.py #111

Closed
wants to merge 1 commit into from
Closed

Update cli.py #111

wants to merge 1 commit into from

Conversation

benbugohit
Copy link

Add deleteMissing option as described in zabbix 4.0 api documentation:
https://www.zabbix.com/documentation/4.0/manual/api/reference/configuration/import

Add deleteMissing option as described in zabbix 4.0 api documentation:
https://www.zabbix.com/documentation/4.0/manual/api/reference/configuration/import
@paalbra
Copy link
Contributor

paalbra commented Nov 11, 2019

As far as I can tell there is no bug here. This PR would break current behavior (since it's altering the default).

It would be nice if the command supported this as parameters I suppose, but that would require more work.

@benbugohit
Copy link
Author

benbugohit commented Nov 11, 2019

It's not about a bug, but about a feature :) since deleteMissing option is supported in zabbix 3.0 API also.
IMO default behavior is inconsistent concerning not deleting missing applications/items/triggers in newly imported templates:
It doesn't clean up configuration in my use case.
Concerning the option, it's a good idea.
As an example, it's available in this other project:
https://github.com/q1x/zabbix-gnomes/blob/master/ztmplimport.py
starting line 123

@paalbra
Copy link
Contributor

paalbra commented Nov 12, 2019

I've created this enhancement as a new issue #114 . I'm closing this PR since a merge would alter the current behavior.

Feel free to add comments in the new issue.

@paalbra paalbra closed this Nov 12, 2019
@benbugohit benbugohit deleted the patch-1 branch November 12, 2019 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants