Add a second type of profile that samples after wakeup #5883
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the time-based profiler, when ticks are missed, the profile ticker will record extra information that indicates that the next sample occured after a missed tick. These samples are then assembled into a separate profile that might give information about what is occuring near blocking waits in the program.
|
A Windows test failed; I'm re-running hoping it was a fluke. |
|
It was a fluke |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the time-based profiler, when ticks are missed, the profile ticker will record extra information that indicates that the next sample occurred after a missed tick. These samples are then assembled into a separate profile that might give information about what is occurring near blocking waits in the program.
This also fixes name output for full profiles to file. I'd forgotten to plumb in and use the float names for that part, so it was showing raw hashes in some cases. Now it should show the proper names.