-
Notifications
You must be signed in to change notification settings - Fork 895
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/neural prophet #1436
base: master
Are you sure you want to change the base?
Feat/neural prophet #1436
Conversation
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Codecov ReportBase: 93.94% // Head: 93.21% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## master #1436 +/- ##
==========================================
- Coverage 93.94% 93.21% -0.74%
==========================================
Files 122 123 +1
Lines 10723 10792 +69
==========================================
- Hits 10074 10060 -14
- Misses 649 732 +83
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
…eat/neural-prophet
@@ -0,0 +1,230 @@ | |||
""" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A few generic comments about the PR:
- So far I think that the pinned requirement on Pytorch Lightning will be a no-go for the moment for us unfortunately.
- Could you import the model from
darts/models/__init__.py
? - Could you stash your changes to the two notebooks?
- Your model implementation is missing an abstract method implementation (
_model_encoder_settings
). But this can wait (don't spend more time on this until the dependency situation is figured out).
@BlazejNowicki Thank you for making NeuralProphet accessible to Darts! Let us know if you can use help with supporting more of the model's capabilities. @hrzn Please excuse the delay in responding to the issue you raised. The dependencies were unnecessarily strict and have been relaxed. I hope this helps. |
Thanks a lot @ourownstory ! |
Hi, is this something still be looked into? |
Happy to support anyone wanting to complete this! |
Hello @ourownstory , I would like to do it, it is something I thought it will be good to do but didn't notice that someone else started it before. Any chance you can also assist to finish this PR: #2092? The team has been busy. Cheers. |
Has this been added to darts or still work on progress, if required I can look into this. |
Neural Prophet
Added basic wrapper for Neural Prophet.
Supported features
Univariate ✅
Multivariate ✅
Probabilistic ⬜️
Multiple-series training ⬜️
Past-observed covariates support ✅
Future-known covariates ✅
Other information
Usage examples in notebook:
neural_examples/examples.ipynb
This will be moved to another notebook or completely removed before merge.