Fix/val_sample_weight error for models inherited from RegressionModel #2626
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
madtoinou
requested changes
Dec 30, 2024
CHANGELOG.md
Outdated
| @@ -7,6 +7,8 @@ but cannot always guarantee backwards compatibility. Changes that may **break co | |||
|
|
|||
| [Full Changelog](https://github.com/unit8co/darts/compare/0.31.0...master) | |||
|
|
|||
| - Fix the bug in [#2579 ](https://github.com/unit8co/darts/issues/2579) that causes an error when `val_sample_weight` is set in the CatBoost and XGBoost models. | |||
There was a problem hiding this comment.
Suggested change
| - Fix the bug in [#2579 ](https://github.com/unit8co/darts/issues/2579) that causes an error when `val_sample_weight` is set in the CatBoost and XGBoost models. | |
| - Fix a bug in `RegressionModel` when `val_sample_weight` is used with a single timeseries. [#2626](https://github.com/unit8co/darts/pull/2626) by [Kylin Schmidt](https://github.com/kylinschmidt). |
CHANGELOG.md
Outdated
| @@ -1403,7 +1405,7 @@ ts: TimeSeries = AirPassengers().load() | |||
| ```python | |||
| # Assuming a multivariate TimeSeries named series with 3 columns or variables. | |||
| # To apply fn to columns with names '0' and '2': | |||
|
|
|||
There was a problem hiding this comment.
Can you revert this change and the others below?
| @@ -588,7 +588,7 @@ def _add_val_set_to_kwargs( | |||
| val_weights = val_weights or None | |||
| else: | |||
| val_sets = [(val_samples, val_labels)] | |||
| val_weights = val_weight | |||
| val_weights = [val_weight] | |||
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2626 +/- ##
==========================================
- Coverage 94.27% 94.19% -0.08%
==========================================
Files 141 141
Lines 15552 15552
==========================================
- Hits 14661 14649 -12
- Misses 891 903 +12 ☔ View full report in Codecov by Sentry. |
dennisbader
approved these changes
Feb 14, 2025
There was a problem hiding this comment.
Thanks @KylinSchmidt for this fix 🚀 I took the liberty to push some changes (unit tests, and the suggestions from @madtoinou ).
Everything looks great now, ready to merge 💯
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Fix the bug in #2579 that causes an error when
val_sample_weightis set in the CatBoost and XGBoost models.Summary
The CatBoost and XGBoost models, which inherit from the RegressionModel class, encounter an error when setting val_sample_weight. This issue is resolved by modifying the _add_val_set_to_kwargs method in RegressionModel, changing val_weights = val_weight to val_weights = [val_weight].
Other Information