fix PLForecastingModel.configure_torch_metrics() with updated args #2958
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
simplify our wrapper method configure_torch_metrics(), delegate the init and error handling to the torchmetrics.MetricCollection(). The problem was that our if-elif handling got obsolete wrt the MetricCollection capabilities. Fixed: now we support eg. Dict[str, Metric].
breznak
commented
Nov 28, 2025
| if torch_metrics is None: | ||
| torch_metrics = torchmetrics.MetricCollection([]) | ||
| elif isinstance(torch_metrics, torchmetrics.Metric): | ||
| torch_metrics = torchmetrics.MetricCollection([torch_metrics]) |
Author
There was a problem hiding this comment.
MetricsCollection() handles all the supported cases, and tells us correctly if it does not handle some format.
added 2 commits
November 29, 2025 14:06
now raises ValueError, not AttributeError
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #2958 +/- ##
==========================================
- Coverage 95.59% 95.52% -0.07%
==========================================
Files 152 152
Lines 16300 16296 -4
==========================================
- Hits 15582 15567 -15
- Misses 718 729 +11 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist before merging this PR:
Summary
simplify our wrapper method configure_torch_metrics(), delegate the init and error handling to the torchmetrics.MetricCollection().
The problem was that our if-elif handling got obsolete wrt the MetricCollection capabilities.
Fixed: now we support eg. Dict[str, Metric].