MainController now takes a single argument that is the path to the configuration directory. Also, configuration files are now reloaded when leaving the Settings scene. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
instead of specifying the path to each config. MainController is meant to be used with a configuration directory, hence the switch. This change allows all test configs to be opened through settings when running test_blade_runner_manual.py, which wasn't the case previously. Updated test_blade_runner_manual.py to be compatible with these changes. Added _reload_configs(). Reloads configuration files in the configuration directory. MainView has been updated to call _reload_configs() when the settings scene is left. This essentially ensures that the configs are reloaded if any changes are made. Before this commit, the only way to reload the configs was to quit Blade Runner and start it up again.
_search_params_arg are used to reset verify_params and search_params. This is a problem if the search/verification params have been updated through settings, since reload_configs() doesn't update _verify_params_arg or _search_params_arg. FIX: reload_configs() now saves the data from the configuration files that are used to reinitialize SearchParams and VerifyParams. restart() uses that data to reinitialize verify_params and search_params instead of using _verify_params_arg and search_params_arg.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
__init__inMainControllernow takes a path to the configuration directory instead of specifying the path to each config.MainControlleris meant to be used with a configuration directory, hence the switch.This change allows all test configs to be opened through settings when running
test_blade_runner_manual.py, which wasn't the case previously.Updated
test_blade_runner_manual.pyto be compatible with these changes.Added
_reload_configs(). Reloads configuration files in the configuration directory.MainViewhas been updated to call_reload_configs()when the settings scene is left. This essentially ensures that the configs are reloaded if any changes are made. Before this commit, the only way to reload the configs was to quit Blade Runner and start it up again.Fixed restart bug:
BUG: When
restart()is called,_verify_params_argand_search_params_argare used to resetverify_paramsandsearch_params. This is a problem if the search/verification params have been updated through settings, sincereload_configs()doesn't update_verify_params_argor_search_params_arg.FIX:
reload_configs()now saves the data from the configuration files that are used to reinitializeSearchParamsandVerifyParams.restart()uses that data to reinitializeverify_paramsandsearch_paramsinstead of using_verify_params_argandsearch_params_arg.