-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add potential failing test for #110 #115
base: main
Are you sure you want to change the base?
Conversation
@Techn1x is attempting to deploy a commit to the universal-ember Team on Vercel. A member of the Team first needs to authorize it. |
<template> | ||
<div {{logText this.testCase.endResult}} /> | ||
<out>{{this.testCase.endResult}}</out> | ||
<button type="button" {{on "click" this.setTestCase}}></button> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The secret sauce to get the test to fail was using the value in a modifier before using it for something else.
This test passes when either;
- you comment out the div with the modifier, or
- the value is referenced before the modifier (eg adding
{{log this.testCase.endResult}}
to the line before the div, or - you use <
ember 5.5ember 5.6
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This test passes when either;
- or, my production builds seem to behave OK. I can't verify this here in the test though.
so I pulled this down, only to realize that it needs rebased! can you rebase? thanks!! |
ce5469d
to
5525e17
Compare
Whoops! I was operating out of an old fork. Rebased. Feel free to modify / undraft this work how you see fit. I called the test "failing case" for lack of a better name, given I'm not sure what the core problem is that it's testing for |
I'm still investigating, but my worry is that this is related to either of these two PRs: |
Would either of those PRs be expected to exhibit different behaviour between test / prod builds? |
I wouldn't expect a difference in behavior, no -- but that doesn't mean something accidentally didn't happen! 🙈 |
aimed to be a failing test for #110