Proof of concept > OOP based approach #1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OOP based refactoring. This post isn't fully functional! My LCS display hasn't arrived yet. So I can't check the LCD outputs there. Additionally I get an exception on webserver response. The lambdas are hard to debug. Maybe This is the next refactoring step :).
|
That's a major refactor, looks nice though! I consider switching to Websockets for to enable a scheduler where same communication is needed. Also, the HTML stuff could be moved to SPIFFS instead of flash. Let me know once you're done with testing for to merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OOP based refactoring.
This post isn't fully functional! My LCD display hasn't arrived yet. So I can't check the LCD outputs.
Additionally I get an exception on webserver response. The lambdas are hard to debug. Maybe this is the next refactoring step :).