Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: add docs about raw method #271

Merged
merged 3 commits into from
Jun 8, 2024
Merged

Conversation

edimitchel
Copy link
Contributor

πŸ”— Linked issue

Closes #268

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme, or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

Add a chapter about the raw function to bypass potential bad interpretation from reporter.

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

README.md Outdated Show resolved Hide resolved
@Barbapapazes Barbapapazes added the documentation Improvements or additions to documentation label Jan 9, 2024
Copy link

codecov bot commented Jan 9, 2024

Codecov Report

Attention: Patch coverage is 0% with 10 lines in your changes missing coverage. Please review.

Project coverage is 28.11%. Comparing base (24c98ce) to head (5edf0ef).
Report is 8 commits behind head on main.

Files Patch % Lines
examples/raw.ts 0.00% 9 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #271       +/-   ##
===========================================
- Coverage   61.08%   28.11%   -32.97%     
===========================================
  Files          13       41       +28     
  Lines        1380     2998     +1618     
  Branches       58       86       +28     
===========================================
  Hits          843      843               
- Misses        537     2127     +1590     
- Partials        0       28       +28     

β˜” View full report in Codecov by Sentry.
πŸ“’ Have feedback on the report? Share it here.

@Barbapapazes
Copy link
Member

Barbapapazes commented Jan 9, 2024

Do you think you could add an example in ./examples?

README.md Outdated Show resolved Hide resolved
@pi0
Copy link
Member

pi0 commented Jan 9, 2024

Thanks for helping document this feature. BTW keep note that it is an advanced feature I introduced back then as an escape hatch. We probably should consider it.

@edimitchel
Copy link
Contributor Author

@pi0 to be honest, by writing the docs I wasn't feeling comfortable with the strange behavior of reporters when we are passing an object containing an args key..

@edimitchel
Copy link
Contributor Author

I'm not fully confident by doing this documentation as raw method looks like a rescue patch to a potential issue of consola.

I'm wondering why consola permits those conflicts by passing args key? Couldn't we just prefix with an underscore to make virtually private?

Copy link
Member

@pi0 pi0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@pi0 pi0 merged commit 8062a4f into unjs:main Jun 8, 2024
2 of 4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

docs: add explanation about LogObject and raw method
4 participants