rtti: skip generic methods in the legacy VMT method table (fixes upstream#41410) - #41
Open
Moonbot-Tech wants to merge 1 commit into
Open
rtti: skip generic methods in the legacy VMT method table (fixes upstream#41410)#41Moonbot-Tech wants to merge 1 commit into
Moonbot-Tech wants to merge 1 commit into
Conversation
…ream#41410) A published open generic method has no callable body, but the legacy method table writer still counted it and emitted a reference to the generic template symbol, so a valid class failed at link time with an undefined symbol. Make the counting and writing predicates symmetric and exclude tprocdef.is_generic, as the extended RTTI writer already does. Ordinary published methods and real specializations are unaffected. FPC issue: https://gitlab.com/freepascal.org/fpc/source/-/issues/41410 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Moonbot-Tech
changed the title
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1547 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issue #41410: a published open generic method has no callable body, but the legacy method table writer counted it and emitted a reference to the generic template symbol, so a valid
{$M+}class failed at link time with an undefined symbol.Fix. Make the counting and writing predicates in
ncgvmt.passymmetric and excludetprocdef.is_generic, as the extended RTTI writer already does. Ordinary published methods and real specializations are unaffected.Test.
tests/webtbs/tw41410.pp: link error on currentmain, runs after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code