helpers: key distinct type aliases by their own identity (fixes upstream#41564) - #42
Open
Moonbot-Tech wants to merge 1 commit into
Open
helpers: key distinct type aliases by their own identity (fixes upstream#41564)#42Moonbot-Tech wants to merge 1 commit into
Moonbot-Tech wants to merge 1 commit into
Conversation
…eam#41564) The helper key for a record or object was built from the base structure's symbol table, so several distinct aliases of one record (type TA = type TB) shared a single key and lookup returned the helper registered last for any of them. For a df_unique def build the key from the def's own owner and name; plain aliases keep sharing the structural key. FPC issue: https://gitlab.com/freepascal.org/fpc/source/-/issues/41564 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1550 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issue #41564: the helper key for a record or object was built from the base structure's symbol table, so several distinct aliases of one record (
type TA = type TB) shared a single key and lookup returned the helper registered last for any of them.Fix. In
generate_objectpascal_helper_keyadf_uniquedef now keys by its own owner and name; plain aliases keep the structural key. Your helper-key refactor onmainalready routes both registration and lookup through this function, so the change is two lines.Test.
tests/webtbs/tw41564.pp: wrong helper picked on currentmain, correct after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code