generics: keep the with instance for inline specializations (fixes upstream#41711, upstream#41712) - #43
Open
Moonbot-Tech wants to merge 1 commit into
Open
Conversation
…stream#41711, upstream#41712) An inline specialization of a generic method reached through a with statement was created without its instance, so the call was rebuilt from the enclosing method's Self and dispatched to the wrong object (#41711), or rejected as an illegal expression (#41712). Resolve the member read first and attach the resulting instance node to the specialize node; a non-member specialization keeps passing nil. FPC issues: https://gitlab.com/freepascal.org/fpc/source/-/issues/41711 https://gitlab.com/freepascal.org/fpc/source/-/issues/41712 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1553 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issues #41711 and #41712: an inline specialization of a generic method reached through a
withstatement was created without its instance. The call was then rebuilt from the enclosing method'sSelfand dispatched to the wrong object (#41711), or rejected as an illegal expression (#41712).Fix. In
pexpr.pasresolve the member read first and attach the resulting instance node to the specialize node; a non-member specialization keeps passingnil. This overlaps with your FPC merge request !1435, which attaches the with-ref only; resolving the member read also covers the member-scope case of #41711.Tests.
tests/webtbs/tw41711.pp(member and globalwith, checks which object is called) andtests/webtbs/tw41712.pp: illegal expression on currentmain, both run after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code