init: run Initialize for static arrays of managed records (fixes upstream#41451) - #45
Open
Moonbot-Tech wants to merge 1 commit into
Open
init: run Initialize for static arrays of managed records (fixes upstream#41451)#45Moonbot-Tech wants to merge 1 commit into
Moonbot-Tech wants to merge 1 commit into
Conversation
…ream#41451) Implicit finalization already covered managed static variables, but the paired initialization only accepted a top-level record or object, so a fixed array of advanced records received Finalize without Initialize. Add one value-storage predicate, has_non_trivial_value_init, that recurses only through records, fixed arrays and old-style objects, and use it both for the initialization walk and for the sto_has_non_trivial_init symtable flag. Class and interface references are excluded, so a large static string array is still initialized by a single zero fill. FPC issue: https://gitlab.com/freepascal.org/fpc/source/-/issues/41451 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1548 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issue #41451: implicit finalization already covered managed static variables, but the paired initialization only accepted a top-level record or object, so a fixed array of advanced records received
FinalizewithoutInitialize.Fix. Add one value-storage predicate,
has_non_trivial_value_init, that recurses only through records, fixed arrays and old-style objects, and use it both for the initialization walk inngenutil.pasand for thesto_has_non_trivial_initsymtable flag. Class and interface references are excluded, so a large static string array is still initialized by a single zero fill.Test.
tests/webtbs/tw41451.pp: the array element'sInitializedoes not run on currentmain, runs after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code