generics: defer the VMT of a partial specialization (fixes upstream#41788) - #51
Open
Moonbot-Tech wants to merge 1 commit into
Open
generics: defer the VMT of a partial specialization (fixes upstream#41788)#51Moonbot-Tech wants to merge 1 commit into
Moonbot-Tech wants to merge 1 commit into
Conversation
…1788) A specialization whose arguments still contain parameters of the enclosing generic has no generated method bodies. Phase 2 already kept such a def out of the pending specializations, but ncgvmt still emitted a VMT with references to the missing bodies, so linking failed with an undefined symbol. Move the unresolved-parameters check to tstoreddef.has_generic_paras and use it in ncgvmt as well. The VMT layout is still built to validate overrides in partial descendants; concrete specializations are unchanged. FPC issue: https://gitlab.com/freepascal.org/fpc/source/-/issues/41788 Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
fibodevy
added
the
waiting-upstream
Author
|
FPC merge request: https://gitlab.com/freepascal.org/fpc/source/-/merge_requests/1556 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem. FPC issue #41788: a specialization whose arguments still contain parameters of the enclosing generic has no generated method bodies. Phase 2 already kept such a def out of the pending specializations, but
ncgvmtstill emitted a VMT with references to the missing bodies, so linking failed with an undefined symbol.Fix. Move the unresolved-parameters check from a local helper in
pgenutil.pastotstoreddef.has_generic_parasand use it inncgvmt.pasas well. The VMT layout is still built to validate overrides in partial descendants; concrete specializations are unchanged.Test.
tests/webtbs/tw41788.pp: link error on currentmain, runs after the fix.Validation. Win64 build of
main(a359fc1) with the patch; 405 neighbouring tests fromtests/test(inline, rtti, helpers, generics, opt) give identical results before and after.🤖 Generated with Claude Code