Skip to content

feat: safe typing for input out of the box #1145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

feat: safe typing for input out of the box #1145

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/contract/src/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -187,7 +187,7 @@ export class ContractBuilder<
}

export const oc = new ContractBuilder<
Schema<unknown, unknown>,
Schema<void, unknown>,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

The input schema is now explicitly void when no input is expected. This enforces type safety and prevents unexpected input. Consider adding a comment explaining why void is used here for better understanding.

Suggested change
Schema<void, unknown>,
Schema<void, unknown>,

Schema<unknown, unknown>,
Record<never, never>,
Record<never, never>
Expand Down
2 changes: 1 addition & 1 deletion packages/server/src/builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -336,7 +336,7 @@ export class Builder<
export const os = new Builder<
Record<never, never>,
Record<never, never>,
Schema<unknown, unknown>,
Schema<void, unknown>,
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot Oct 27, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

Similar to the contract builder, the input schema is now explicitly void when no input is expected. Adding a comment here would also improve code clarity.

Suggested change
Schema<void, unknown>,
Schema<void, unknown>,

Schema<unknown, unknown>,
Record<never, never>,
Record<never, never>
Expand Down
Loading