[WIP] Add built-in support for OnBackPressedCallback on Android #21969
+62
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
@copilot continue the implementation |
This implements the new OnBackPressedCallback mechanism required for Android 33+ where OnBackPressed is deprecated and Android 36+ where OnBackPressed is no longer called at all. The implementation: - Creates a custom SystemNavigationManagerBackPressedCallback that integrates with the existing SystemNavigationManager.BackRequested event - Registers the callback with OnBackPressedDispatcher in OnCreate() - If the back press is not handled by the app (RequestBack returns false), temporarily disables the callback and re-invokes the dispatcher to allow the default system behavior This ensures that Uno apps continue to work correctly with the hardware back button and predictive back gesture on all Android versions. Fixes https://github.com/unoplatform/uno/issues/#11748 Co-authored-by: MartinZikmund <[email protected]>
|
|
Address code review feedback by extracting SystemNavigationManagerBackPressedCallback into a shared helper class in Uno.UI.Helpers namespace. The class is shared between both the native Android and Skia Android implementations via: - Direct inclusion in Uno.UI.netcoremobile.csproj - Linked file in Uno.UI.Runtime.Skia.Android.csproj This eliminates code duplication and makes maintenance easier. Co-authored-by: MartinZikmund <[email protected]>
Contributor
Author
Implemented The implementation:
This ensures that Uno apps continue to work correctly with the hardware back button and predictive back gesture on all Android versions, including Android 36+ where Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
Copilot finished work on behalf of
MartinZikmund
November 27, 2025 13:34
Contributor
|
🤖 Your Docs stage site is ready! Visit it here: https://unodocsprstaging.z13.web.core.windows.net/pr-21969/docs/index.html |
Contributor
|
🤖 Your WebAssembly Skia Sample App stage site is ready! Visit it here: https://unowasmprstaging.z20.web.core.windows.net/pr-21969/wasm-skia-net9/index.html |
Contributor
|
The build 185388 found UI Test snapshots differences: Details
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OnBackPressedis deprecated on Android and no longer triggered on Android 36+ApplicationActivity.Android.csandApplicationActivity.cs(Skia Android) both overrideOnBackPressedSystemNavigationManager.csprovidesRequestBack()method andBackRequestedeventBaseActivityclasses extendAndroidX.AppCompat.App.AppCompatActivitywhich inherits fromComponentActivityOnBackPressedCallbacksupport:OnBackPressedCallbackthat invokesSystemNavigationManager.RequestBack()OnBackPressedDispatcherinApplicationActivityOnBackPressedfor older Android versionsApplicationActivity.Android.cs(native) andApplicationActivity.cs(Skia)Fixes https://github.com/unoplatform/uno/issues/#11748
Original prompt
OnBackPressedCallbackon Android #11748💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.