Issue 38 (#40)

* Fixed WithIEnumerableAndConditionEqualsTrue_ReturnsIEnumerable

* my two cents

* Reducing methods on DI

* Added tests for Contains, Retrieve, GetAllPropertiesFunc, GetAllPublicPropertiesFunc, GetAllFieldsFunc classes

* Modified variable names

* API Analyzer

* Update Nugets

* Added DnsQueryResultTest class

* Delete DnsQueryResultTest.cs

* MessageHubTest class refactored. MessageHubMessageBase ctor => NullSender_ThrowsArgumentNullException test method added (WIP)

* Changed docfx.json and appveyor.yml

* Added some asserts in ValidDnsAndTXTAsDnsRecordType_ReturnsQueryDns

* MessageHubMessageBase ctor => NullSender_ThrowsArgumentNullException test method changed (WIP)

* Revert Json suggestion

* Minor changes (WIP)

* MessageHubMessageBase ctor => NotNullSender_ReturnsSuccess test method changed (WIP)

* Used swan-logo in docfx.json and changes to appveyor.yml

* Modified variable names, and added a message to some asserts

* Changed doc-logo

* MessageHubCancellableGenericMessage ctor => NullCancel_ThrowsArgumentNullException test method added (WIP)

* MessageHubCancellableGenericMessage ctor => ValidCancel_ReturnsSuccess test method added (WIP)

* Reduce overhead Tests

* CR TypeCacheTest

* Missing doc

* Documentation

* Documentation

* Documentation

* Modified variable names in EnumHelperTest, and added JsonSerializerTest

* MessageHubSubscriptionToken ctor => NullHub_ThrowsArgumentNullException test method added (WIP)

* MessageHubSubscriptionToken ctor => MessageType_ThrowsArgumentOutOfRangeException test method added (WIP)

* Changed the tests inside JsonSerializerTest to Json Test and deleted JsonSerializerTest, and added new tests

* Added WithString_ReturnsString, WithEmptyString_ReturnsEmptyString in JsonTest

* Change JSON Serialize method signature

* Fixing test for Travis

* Updating NUnit

* Fix appveyor.yml

* Fix JSON Serialize compatibility

* Added WithStringsArrayAndWeakReference

* changed List<WeakReference> to var

* Fix Samples build

* Remove AssemblyInfo from Samples

* Hello Rusky!

* Modified WithStringsArrayAndWeakReference_ReturnsArraySerialized()

* Added WithIncludeNonPublic_ReturnsObjectDeserialized() in Deserializa class

* Console.WriteLine removed

* MessageMock class changed (to public). Variables reduced in the MessageHubTest test class

* MessageHub.PublishInternal => NullMessage_ThrowsArgumentNullException test method added

* MessageHub.Publish => NotNullMessage_ReturnsSuccess test method added. Minor changes in NullMessage_ThrowsArgumentNullException test method

* ExtensionsReflectionTest Refactored

* Minor changes

* Added some tests to check if some methods throw an ArgumentNullException, and added WithAssembly_ReturnsTypeObjects

* MessageHub.Publish => NullDeliveryAction_ThrowsArgumentNullException test method added

* MessageHub.Publish => NullProxy_ThrowsArgumentNullException test method added

* MessageHub.Publish => NullFunc_ThrowsArgumentNullException test method added

* MessageHub.Publish => StrongReferenceFalse_ReturnsSuccess test method added

* messageFilter param changed to lambda expression

* MessageHub.Unsubscribe => NullToken_ThrowsArgumentNullException test method added

* GetMethod test class added

* DependencyContainerTest Refactored

* MessageHub.Unsubscribe => NullToken_ThrowsArgumentNullException test method changed

* Changes to MessageHub

* MessageHub.Subscribe => DeliveryActionAndProxy_ReturnsSuccess test method added

* Some tests added in DependencyContainerTest

* MessageHub.Subscribe => DeliveryActionAndStrongReferencesTrue_ReturnsToken test method added. Some minor changes in the header of the test methods

* MessageHub.Subscribe => DeliveryActionAndStrongReferencesFalse_ReturnsToken test method added

* MessageHub.Subscribe => DeliveryActionWithStrongReferencesTrueAndProxy_ReturnsToken test method added

* MessageHub.Subscribe => DeliveryActionWithStrongReferencesFalseAndProxy_ReturnsToken test method added

* MessageHub.Subscribe => DeliveryActionAndMessageFilter_ReturnsToken test method added

* Tests Added in Resolve and TryResolve classes,

* MessageHub.Subscribe => DeliveryActionWithFuncAndStrongReferencesTrue_ReturnsToken test method added

* Added ResolveAll class, and added some tests in TryResolve

* Added testcases to some tests in DependencyContainer

* MessageHub.Publish => PublishWithStrongReference_ReturnsMessagePublished and PublishWithWeakReference_ReturnsMessagePublished test methods added. Minor changes in some methods

* Added WithInvalidRegisterImplementation_ThrowsDependencyContainerRegistrationException

* MessageHub.Publish => PublishMessage_MessagePublished test method added. PublishMessage_ReturnsSuccess test method splitted and deleted

* Improvements to MessageHub

* Minor change DI

* WithType_RegisterDictionary test added

* MessageHub.Publish => PublishMessageWhenUnsubscribed_MessageNotPublished test method added.

* Minor changes.

* CsvWriter.WriteObject => DynamicObject_ReturnsAreEqual test method added

* Minor changes

* Changes to Reflection Unit Testing

* Some tests fixed and recreated

* WithTypeAndParent_ResolveType and WithRegisterImplementationAsSingleton_ThrowsDependencyContainerRegistrationException tests added

* Checking ConnectionListenerTest

* Changed to net46 framework to take as principal to run tests

* Update CsvWriter.cs

* Modify LdapTest

* Add ldapjs installation command

* CsvWritter.WriteHeadings => NullType_ThrowsArgumentNullException test method added

* Minor changes

* Deactivate ReadUserProperties Test for AppVeyor CI

* Applying Rusky suggestions

* CsvWritter.WriteHeadings => NullDictionary_ThrowsArgumentNullException test method added

* CsvWritter.WriteHeadings => HeadersDictionaryLength_ReturnsAreEqual test method added. Some minor changes made

* WithTypeAsParamAndWithParent_ResolveAll And RegisterInterfaceWithInstance_ThrowsDependencyContainerRegistrationException tests added

* Minor changes

* _aux variable deleted

* Modified some tests inside the class ResolveAll

* WithInvalidRegisterImplementation_ThrowsDependencyContainerResolutionException test modified

* Teaching DI

* Modified some tests in the TryResolve class

* Reduce complexity at CsvWriter

* Modified WithTypeAndParent_ResolveType test

* CsvWritter.SaveRecords => TempFileFilled_SetStreamLengthToZero test method added

* Reduce MessageHub complexity

* Include CSV Helper methods with stream (Rusky suggestion)

* Modified some tests in the TryResolve class, and deleted DependencyContainerTest

* Cleaning MessageHub

* Minor changes

* Modified some tests in the ResolveAll class

* Modified tests in the CanResolve class

* Modified test name

* Minor changes

* Minor changes

* Minor changes

* Some test names were modified and a test case was added for WithTypeAndParent_ResolveType

* Split DependencyContainer in files

* Why!

* Checking JSON Serializer

* Enabling Code Style to Unit Test project

* New String runcate method

* Fixing some unit tests

* Upgrade Test SDK

* Minor change

* Checking style

* HeadersDictionaryLength_ReturnsAreEqual test method changed (MemoryStream class used instead of File.OpenWrite())

* HeadersLength_ReturnsAreEqual test method changed (MemoryStream class used instead of File.OpenWrite())

* WithAssembliesAndFunc_ResolvesIAnimal test added

* Minor changes

* Minor changes

* Added some tests to check if JsonClientTest throw an ArgumentNullException

* Minor changes

* Modified some tests inside JSonClientTest

* Minor changes (names of the test methods for WriteHeadings() changed). PR solved

* Added WithAssembliesAndRegisterMultiple_ResolvesICar, and modified WithFailDependencyContainer_ThrowsDependencyContainerRegistrationException

* TerminalTest class splitted and refactored. The abstract class was left for future possible settings

* WithRegister_ResolveContainer, WithFailUnregisteredResolutionActions_FailResolveContainer and WithRegisterAndAttemptUnnamedResolution_ResolveContainer tests added

* TerminalLoggingTest class created from the LoggingTest method in TerminalTest class

* WithRegisterAndAttemptUnnamedResolution_ResolveContainer, WithInvalidTypeAndAttemptUnnamedResolution_ThrowsDependencyContainerResolutionException, and WithRegisterAndStringAndDictionary_ResolveType tests added

* Abstract class removed

* Terminal.Logging.Log => Message_MessageLoaded test method added

* Added a testcase to RegisterTypeWithInstance_ThrowsDependencyContainerRegistrationException

* Checking Tests

* More cleaning

* Test Fixture Base

* WithInstanceAndRegister_ResolveContainer test added

* Terminal.Logging.Debug => MessageWithException_MessageLogged test method added

* Minor changes

* A setup method created in the abstract class (SetupLoggingMessages)

* Terminal.Logging.Trace => MessageWithException_MessageLogged test method added

* Terminal.Logging.Trace => MessageWithType_MessageLogged test method added

* Cleaning Tests

* Minor changes: Terminal.Flush was moved to the SetupLoggingMessages() setup method and param of Trace in MessageWithType_MessageLogged changed to typeof(string)

* Working working working

* Checking issues

* Modified some tests inside DependencyContainerTest and ExtensionsStringTest

* Minor change to ObjectMapperTest

* Changes in the test methods MessageWithException_MessageLogged() for the Debug and Trace test classes

* Minor changes

* Changes LDAP

* An internal list was added to the PublishMessageAsync_ReturnsSuccess() test method

* Minor changes

* Modified test name in NetworkTest

* Minor changes

* New Reflection method and checking before merge

* My bad

* Reduce Dictionaries

* Terminal.Logging.Warn => MessageWithType_MessageLogged() test method added

* Rename CopyPropertiesTo to CopyKeyValuePairTo when a IDictionary is used.

* Terminal.Logging.Info => MessageWithException_MessageLogged() test method added

* Terminal.Logging.Error => MessageWithType_MessageLogged() test method added

* Modified tests inside ResolveAll

* Terminal.Logging.Warn => MessageWithException_MessageLogged() test method added

* Terminal.Logging.Log => MessageWithType_MessageLogged() test method added

* Terminal.Logging.Log => MessageWithException_MessageLogged() test method added

* Attribute ([Test]) added to NullMessageFilter_ThrowsArgumentNullException() test method

* Terminal.Logging.Dump => NullObject_ReturnsNothing() test method added

* Terminal.Logging.Dump => NotNullObject_MessageLogged() test method added

* ExtensionsValueTypeTest refactored

* Modified test name

* Terminal.Logging.Dump => NotNullObject_MessageLogged() test method changed. NotNullObjectAcceptingType_ReturnsNothing test method created. NullObjectAcceptingType_ReturnsNothing() and NullObject_ReturnsNothing() test methods changed

* SingletonBaseTest refactored

* WithNullIPAddress_ReturnsDnsHost test added

* ProcessHelperTest refactored

* Final check

* Refactor Terminal tests

* My bad

LdapClient.js

@@ -1,11 +1,13 @@
 var ldap = require('ldapjs');
 var client = ldap.createClient({
-    url: 'ldap://127.0.0.1:389'
+    url: 'ldap://127.0.0.1:1089'
 });
 
-client.bind('cn=root', 'secret', function (err) {
-    console.log(err);
-})
+client.bind('cn=root',
+    'secret',
+    function (err) {
+        console.log(err);
+    });
 
 var entries = [
     {

Unosquare.Swan.sln

@@ -1,15 +1,19 @@
 
 Microsoft Visual Studio Solution File, Format Version 12.00
 # Visual Studio 15
-VisualStudioVersion = 15.0.26730.10
+VisualStudioVersion = 15.0.27004.2006
 MinimumVisualStudioVersion = 10.0.40219.1
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "src", "src", "{2D969810-4C1B-4354-9D55-5961EFF55AB3}"
 EndProject
 Project("{2150E333-8FDC-42A3-9474-1A3956D46DE8}") = "Solution Items", "Solution Items", "{2B307C2C-8FC4-492F-80D7-D56F818C8482}"
 	ProjectSection(SolutionItems) = preProject
 		.travis.yml = .travis.yml
 		appveyor.yml = appveyor.yml
+		docfx.json = docfx.json
+		ldap.js = ldap.js
+		LdapClient.js = LdapClient.js
 		LICENSE = LICENSE
+		mail.js = mail.js
 		README.md = README.md
 		StyleCop.Analyzers.ruleset = StyleCop.Analyzers.ruleset
 	EndProjectSection

appveyor.yml

@@ -34,7 +34,7 @@ build_script:
 - msbuild /p:Configuration=%CONFIGURATION%
 test_script:
 - dotnet test test/Unosquare.Swan.Test/Unosquare.Swan.Test.csproj -c %CONFIGURATION% -f netcoreapp2.0
-- tools\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:"%ProgramFiles%\dotnet\dotnet.exe" -targetargs:"test test/Unosquare.Swan.Test/Unosquare.Swan.Test.csproj -c %CONFIGURATION% -f net452" -output:coverage.xml -filter:"+[Unosquare.Swan*]* -[Unosquare.Swan.Test*]*" -register:userdotnet
+- tools\OpenCover.4.6.519\tools\OpenCover.Console.exe -target:"%ProgramFiles%\dotnet\dotnet.exe" -targetargs:"test test/Unosquare.Swan.Test/Unosquare.Swan.Test.csproj -c %CONFIGURATION% -f net46" -output:coverage.xml -filter:"+[Unosquare.Swan*]* -[Unosquare.Swan.Test*]*" -register:userdotnet
 - ps: |
         if(-Not $env:APPVEYOR_PULL_REQUEST_TITLE)
         {
@@ -44,13 +44,14 @@ after_build:
 - ps: |
         if(-Not $env:APPVEYOR_PULL_REQUEST_TITLE)
         {
-            docfx docfx.json --logLevel Error
             git config --global credential.helper store
             Add-Content "$env:USERPROFILE\.git-credentials" "https://$($env:access_token):[email protected]`n"
             git config --global core.autocrlf false 
             git config --global user.email $env:op_build_user_email
             git config --global user.name $env:op_build_user
             git clone https://github.com/unosquare/swan.git -b gh-pages origin_site -q
+            git clone -b documentation https://github.com/unosquare/best-practices.git -q
+            docfx docfx.json --logLevel Error
             Copy-Item origin_site/.git _site -recurse
             CD _site
             Copy-Item README.html index.html -force

docfx.json

@@ -11,6 +11,9 @@
     }
   ],
   "build": {
+    "template": [
+      "best-practices/templates/default"
+    ],
     "content": [
       {
         "files": [ "**/*.yml" ],
@@ -23,12 +26,14 @@
     ],
     "resource": [
       {
-        "files": [ ]
+        "files": [ "best-practices/resources/**", "swan-logo-256.png"]
       }
     ],
     "globalMetadata": {
       "_appTitle": "Unosquare SWAN",
-      "_enableSearch": true
+      "_enableSearch": true,
+      "_docLogo":  "swan-logo-256.png",
+      "_appLogoPath": "best-practices/resources/images/logo.png"
     },
     "dest": "_site"
   }