Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(AnimatedBeam): fix the direction of beam animation execution #154

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

hooray
Copy link
Contributor

@hooray hooray commented Mar 11, 2025

The original plan was to compare the positions of the fromRef and toRef elements on the page, and the final execution direction of the beam animation could be from fromRef to toRef, or from toRef to fromRef, which is very uncontrollable because the positions of fromRef and toRef may change due to responsive layouts.

The modified plan is that the beam animation will always be from fromRef to toRef, which is also more in line with the semantics of these 2 props.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant