-
Notifications
You must be signed in to change notification settings - Fork 322
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weβll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: init CLI and @nuxtjs/color-mode module config #886
base: dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@selemondev Thanks for the PR
Please add @nuxtjs/tailwindcss
and @nuxtjs/color-mode
to the shadcn-nuxt
package.json dependencies.
Remove TypeScript from dependencies maybe?
Could you please revert the CLI init
changes? because there is a manual installation module way
We don't need to force user to use shadcn-nuxt
Related #883
Hey there @sadeghbarati, thanks for taking the time to review my PR and leave a comment π. Let me know what you think of these:
|
Thanks for the PR @selemondev , at first the idea of the |
Hey @zernonia, I have updated the documentation. Here is what I have done:
@sadeghbarati, for now we can work with automatically installing the |
Any news? |
π Linked issue
Fixes: #864
β Type of change
π Description
This pull request is intended to do two things namely:
Configure the @nuxtjs/color-mode module by adding the
classSuffix: ''
property as shown below:await installModule('@nuxtjs/color-mode', { classSuffix: '' })
.Refactor the init CLI by ensuring that the
shadcn-nuxt
module is installed when the selected framework is Nuxt and the base dependencies as well.πΈ Screenshots (if appropriate)
π Checklist