Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add support for File type in Input component #941

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

Dam998
Copy link

@Dam998 Dam998 commented Dec 5, 2024

πŸ”— Linked issue

No open issue exists, but this change improves the handling of file inputs.

❓ Type of change

  • πŸ“– Documentation (updates to the documentation, readme or JSdoc annotations)
  • 🐞 Bug fix (a non-breaking change that fixes an issue)
  • πŸ‘Œ Enhancement (improving an existing functionality like performance)
  • ✨ New feature (a non-breaking change that adds functionality)
  • 🧹 Chore (updates to the build process or auxiliary tools and libraries)
  • ⚠️ Breaking change (fix or feature that would cause existing functionality to change)

πŸ“š Description

The Input component now supports the File type for both modelValue and defaultValue. This enhancement allows the component to work seamlessly with file inputs without causing type errors or warnings.

What has changed:

  • Added File as a valid type for the modelValue and defaultValue props.
  • This change is fully backward-compatible and does not affect existing functionality.

Why this change is needed:
Currently, when using the Input component with type="file", Vue emits a warning for an invalid prop type. This update enables the component to natively handle the File type, improving flexibility and usability.

image

πŸ“ Checklist

  • I have linked an issue or discussion.
  • I have updated the documentation accordingly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant