Skip to content

Sleep trl patch #3517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 4, 2025
Merged

Sleep trl patch #3517

Changes from all commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
d4370c5
Patch sleep mode properly for trl
Datta0 Oct 22, 2025
e7fbc8a
Merge remote-tracking branch 'origin/main' into sleep_trl_patch
Datta0 Oct 22, 2025
b34e8ac
empty cache after sleep/wakeup
Datta0 Oct 22, 2025
72120fb
no extra wakeups
Datta0 Oct 22, 2025
97b3540
Do not redo wakeups
Datta0 Oct 22, 2025
e3087f9
cleanup
Datta0 Oct 22, 2025
9f8f9a7
Merge remote-tracking branch 'origin/main' into sleep_trl_patch
Datta0 Oct 27, 2025
dfc8d3e
post trl 0.23 sleep patch
Datta0 Oct 27, 2025
ec73527
Merge branch 'main' into sleep_trl_patch
Datta0 Nov 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 7 additions & 2 deletions unsloth/models/rl.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -950,8 +950,13 @@ def patch_functions(RLTrainer, trainer_file, RLTrainer_name, all_imports, import
if "grpo" in trainer_file and trl_version >= Version("0.18.0"):
# If model has vllm_engine, then use vllm in colocate mode. Donot wait for server
vllm_setter += \
" " * 12 + "args.vllm_mode='colocate'\n"

" " * 12 + "args.vllm_mode='colocate'\n"
if trl_version >= Version("0.23.0"):
# We need to set this flag for sleep mode auto working with trl update
vllm_setter += \
" " * 12 + "if os.environ.get('UNSLOTH_VLLM_STANDBY', '0') == '1':\n" + \
" " * 16 + "args.vllm_enable_sleep_mode=True\n"

init = init.replace(replacer, replacer + vllm_setter)
pass
pass
Expand Down