- 
                Notifications
    You must be signed in to change notification settings 
- Fork 35
359 feature exception handling #368
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main-dev
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks bad. Changing indent in every line just to fit try-catch blocks isn’t a solutions.
        
          
                src/engine_leveldb.cpp
              
                Outdated
          
        
      |  | ||
| linked_memory_lock_t arena = linked_memory(c.arena, c.options, c.error); | ||
| return_if_error_m(c.error); | ||
| safe_section("Geting Snapshot List", c.error, [&] { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling.
        
          
                src/engine_rocksdb.cpp
              
                Outdated
          
        
      |  | ||
| linked_memory_lock_t arena = linked_memory(c.arena, c.options, c.error); | ||
| return_if_error_m(c.error); | ||
| safe_section("Geting Snapshot List", c.error, [&] { | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spelling.
Exception handling