fix: disable benchmark runs for feature branches#492
fix: disable benchmark runs for feature branches#492MANASAB805 wants to merge 3 commits intounyt-org:release/0.0.7from
Conversation
|
This does not solve the issue though, can you double check? |
|
@jonasstrehle I've updated the PR to correctly exclude feature branches. The workflow is now working as expected: Changes made:
The workflow will now:
|
| - uses: katyo/publish-crates@v2 | ||
|
|
||
| - name: Run cargo publish dry-run | ||
| run: cargo publish --dry-run --allow-dirty |
There was a problem hiding this comment.
please remove the dry run here, we don't have any benefit in doing this, as we already perform the dry run in the release/xx branch as required action to be passed before we can merge.
|
Could you take a look at the two comments and also rebase this branch to the release/0.0.7 please? |
20822b1 to
cbf6a25
Compare
|
@jonasstrehle I've addressed all your feedback:
The PR is now ready for your review. All checks have passed, and the changes are up to date with the target branch. Changes Made:
Let me know if you need any further adjustments! |
Description
This PR modifies the PR benchmarks workflow to skip running benchmarks for feature branches, as they can be time-consuming and may clutter the benchmark history. Benchmarks will now only run for:
release/*)hotfix/*)Changes
Testing
Related Issues
Closes #463