Change dev port to 3022 and reformat JS#194
Open
siefkenj wants to merge 33 commits intouoft-tapp:masterfrom
Open
Change dev port to 3022 and reformat JS#194siefkenj wants to merge 33 commits intouoft-tapp:masterfrom
siefkenj wants to merge 33 commits intouoft-tapp:masterfrom
Conversation
The port 3000 is used by default by a lot of web development environments. Changing the port to 3022 will prevent clashing when working on multiple web projects on the same computer.
Allow most fields to be missing when importing CHASS data
Newer versions of react give better warnings. Upgrade to 16.8
Contracts are now rendered from html files first using the liquid templating engine and then to PDF using wkhtmltopdf. The Docker image has been modified to include a version of the wkhtmltopdf binary.
Uglifyjs is removed from the new webpack. The new rake, when runing bundle install --deployment won't put rails in the system path. `bundle exec rails` is needed to run it
If a field was empty, its content would render at 0 height preventing the edit button from appearing. Now there's a minimum height.
Added barebones UI for creating new assignments, applicants, and offers without the need to hand-edit and upload JSON
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR includes two changes:
The development port was changed from 3000 to 3022 to avoid clashes with other dev projects on the same computer (webpack by default serves to port 3000).
Reformatted javascript files with prettier.js. This will make it much easier to consistently format code in the future.