Skip to content

additional front-end features#30

Merged
michellemtchai merged 23 commits intomasterfrom
ui-dev
Aug 30, 2017
Merged

additional front-end features#30
michellemtchai merged 23 commits intomasterfrom
ui-dev

Conversation

@gabriellesc
Copy link
Collaborator

@gabriellesc gabriellesc commented Aug 27, 2017

Port of CP PR #34: uoft-tapp/cp#34

  • checkbox range selection
  • table in-column searching
  • email templating with mangled applicant contract URL
    doesn't seem to be possible, since fetching the mangled contract URL would expose a vulnerability
    @michellemtchai what do you think?
  • session selection
  • modifying sessional pay

@michellemtchai:

@gabriellesc I can open up an admin only route GET /decision/:utorid/:position_id like before. This way the students gets their mangled routes and we get the readable routes for the admin.

@gabriellesc:

@michellemtchai what would that route return?

@michellemtchai:

@gabriellesc It would render the student-facing view. It's the same page the applicant sees when they click on the mangled link.

@gabriellesc:

@michellemtchai This would be for the purpose of inserting the mangled link into an email to send to people, not just for seeing the student-facing view

@michellemtchai:

@gabriellesc That can be an extra route or it can be part of the /offers fetch. Which do you prefer?

@gabriellesc
Copy link
Collaborator Author

@michellemtchai I suppose it makes sense to make it part of the /offers fetch?

@gabriellesc gabriellesc force-pushed the ui-dev branch 2 times, most recently from 0119242 to c8c5fac Compare August 29, 2017 21:16
@gabriellesc gabriellesc changed the title [WIP] additional front-end features additional front-end features Aug 29, 2017
@michellemtchai michellemtchai merged commit 7706603 into master Aug 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants