fix issue with returning existing assessment

upmaru · Jul 2, 2024 · 790b752 · 790b752
1 parent 0fb3d3a
commit 790b752
Show file tree

Hide file tree

Showing 2 changed files with 26 additions and 1 deletion.
diff --git a/lib/polar/machines/assessment/manager.ex b/lib/polar/machines/assessment/manager.ex
@@ -14,7 +14,7 @@ defmodule Polar.Machines.Assessment.Manager do
     )
     |> case do
       %Assessment{} = assessment ->
-        assessment
+        {:ok, assessment}
 
       nil ->
         create(version, params)

diff --git a/test/polar_web/controllers/publish/testing/assessment_controller_test.exs b/test/polar_web/controllers/publish/testing/assessment_controller_test.exs
@@ -79,6 +79,31 @@ defmodule PolarWeb.Publish.Testing.AssessmentControllerTest do
       assert %{"id" => _id, "current_state" => "created", "check" => _check} = data
     end
 
+    test "when assessment already exists", %{
+      version: version,
+      conn: conn,
+      check: check,
+      cluster: cluster
+    } do
+      {:ok, _assessment} =
+        Machines.get_or_create_assessment(version, %{
+          check_id: check.id,
+          cluster_id: cluster.id,
+          instance_type: "container"
+        })
+
+      conn =
+        post(conn, ~p"/publish/testing/versions/#{version.id}/assessments", %{
+          "assessment" => %{
+            "check_id" => check.id,
+            "cluster_id" => cluster.id,
+            "instance_type" => "container"
+          }
+        })
+
+      assert %{"data" => _data} = json_response(conn, 200)
+    end
+
     test "invalid parameter passed in", %{
       version: version,
       conn: conn,